added custom placeholder option. #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added custom placeholder option. Users can show placeholder if doesn't selected any item.
added custom placeholder option.
updated placeholder for custom placeholder. I missed update readme.md
JuanRaymundo
suggested changes
Jun 11, 2022
|
Can you check again? @JuanRaymundo |
Users now can set placeholder option from html attribute.
Updated readme.md for set placeholder option from html attribute.
oquis
requested changes
Jun 27, 2022
| @@ -21,6 +22,9 @@ import 'styles/main.scss'; | |||
| beforeDecrement: () => true, | |||
| beforeIncrement: () => true, | |||
| setSelectionText (itemCount, totalItems) { | |||
| if (totalItems == 0 && this.placeHolderText != '') { | |||
There was a problem hiding this comment.
equality and inequality should use === and !== accordingly
| @@ -36,6 +40,7 @@ import 'styles/main.scss'; | |||
| const dataAttrOptions = { | |||
| selectionText: $selection.data('selection-text'), | |||
| textPlural: $selection.data('text-plural'), | |||
| placeHolderText: $this.data("placeholder"), | |||
There was a problem hiding this comment.
strings must use single quotes. you can check for lint errors running yarn lint
| @@ -116,6 +116,8 @@ $(document).ready(() => { | |||
| selectionText: 'item', | |||
| // text to show for multiple items | |||
| textPlural: 'items', | |||
| // text to show placeholder | |||
| placeHolderText: 'Custom Placeholder', | |||
There was a problem hiding this comment.
i think placeholder is a better name so it matches the data-prop attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added custom placeholder option. Users can show placeholder if doesn't selected any item.