Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

fix: Add ; charset=utf-8 to headers. #186

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Et7f3
Copy link

@Et7f3 Et7f3 commented May 6, 2020

this should fix encoding issue we see in embed on discord.
https://vercel.com/docs/configuration#project/headers

@Et7f3
Copy link
Author

Et7f3 commented May 6, 2020

I have closed because I see same behaviour on discord computer and phone so it should be a discord bug.

@Et7f3
Copy link
Author

Et7f3 commented May 6, 2020

Others have fixed with the same fix https://devforum.roblox.com/t/error-with-unicodes-on-discord-embed/503516/11 and it seem that headers change only apply to blog/feed.xml so it seems I have failed my regex.

@Et7f3 Et7f3 reopened this May 6, 2020
@Et7f3
Copy link
Author

Et7f3 commented May 6, 2020

Ok it works.
before: before
after: after
So now maybe we should use another regex to match all html pages not only inside doc. Can we remove the meta tag (that set charset to utf-8) since it is in the headers now ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant