build: allow to skip slow tests #600
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #600 +/- ##
============================================
- Coverage 100.00% 75.20% -24.80%
============================================
Files 15 14 -1
Lines 1071 1319 +248
============================================
- Hits 1071 992 -79
- Misses 0 327 +327 ☔ View full report in Codecov by Sentry. |
kairoaraujo
force-pushed
the
allow-skip-ft
branch
from
003623a
to
38cd126
Compare
It gives us certain flexibility to skip slow when we identify that there is no changes that can affect the performance and skip the slow tests by adding the tag is a commit. [skip slow] Signed-off-by: Kairo de Araujo <[email protected]>
kairoaraujo
force-pushed
the
allow-skip-ft
branch
from
38cd126
to
66adc5f
Compare
|
I am okay with having that option, but let's make sure always we skip slow tests to leave a comment in the pr about that and give a reason. |
|
Code coverage is not happy, but the coverage isn't lower now... I think it lowered based on your previous pr #593. |
Yes, the good thing is that we keep the tests as required. |
|
I will not merge it. |
It gives us certain flexibility to skip slow when we identify that there is no changes that can affect the performance and skip the slow tests by adding the tag is a commit.
[skip slow]