Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to arm/v7 and arm/v8 images #453

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kairoaraujo
Copy link
Member

Include support to arm/v7 and arm/v8 container images.

It includes Apple M processors.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (331e7e7) 100.00% compared to head (715e37e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #453   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines         1035      1035           
=========================================
  Hits          1035      1035           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kairoaraujo kairoaraujo force-pushed the extend_arm_images branch 5 times, most recently from d0be636 to e1db412 Compare February 7, 2024 13:47
MVrachev
MVrachev previously approved these changes Feb 7, 2024
Include support to arm/v7 and arm/v8 container images.

It includes Apple M processors.

Signed-off-by: Kairo Araujo <[email protected]>
@KAUTH
Copy link
Collaborator

KAUTH commented Feb 7, 2024

LGTM, but tests are failing for the ARM build

@kairoaraujo
Copy link
Member Author

I will fix the build before we put it to merge. Moving to Draft

@kairoaraujo kairoaraujo marked this pull request as draft February 7, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants