-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli.admin.helpers): users can now interactively select keys on disk #712
base: main
Are you sure you want to change the base?
feat(cli.admin.helpers): users can now interactively select keys on disk #712
Conversation
Hi @trishankatdatadog, It has very cool functionality! 🎉 To be able to merge it, we will need some extra work (sorry 😃 ):
|
What do you need the tests to do? |
Nvm, I understood day before yesterday after some investigation: |
@kairoaraujo sorry, don't understand: could you tell me why 905a1d5 doesn't work? |
See https://github.com/repository-service-tuf/repository-service-tuf-cli/pull/712/files#r1796535461 Basically when you mock, you need to add all the iterations that will call prompt_toolkit |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
===========================================
- Coverage 98.90% 86.23% -12.67%
===========================================
Files 20 26 +6
Lines 1367 1395 +28
===========================================
- Hits 1352 1203 -149
- Misses 15 192 +177 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@kairoaraujo Sorry it took a while, but:
|
b0989ee
to
8e23d39
Compare
1bb6f21
to
3684eb4
Compare
Description
Users can now interactively select keys as files on disk instead of manually typing or at least pasting their entire paths.
Fixes #(issue): N/A
Types of changes
Additional requirements
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct.