-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example using vite #173
base: master
Are you sure you want to change the base?
Add example using vite #173
Conversation
Thank you @nmrshll for contributing this. We'd be happy to merge it once a few things are sorted.
"scripts": {
"dev": "pnpm run wasm:build && vite",
"build": "pnpm run wasm:build && tsc && vite build",
"preview": "vite preview",
"wasm:build": "cd ../shared && wasm-pack build --target web"
}, |
@@ -0,0 +1,13 @@ | |||
<!doctype html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think all this belongs in simple_counter
, rather than counter
"private": true, | ||
"version": "0.0.0", | ||
"type": "module", | ||
"scripts": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to build the shared
lib?
"scripts": {
"dev": "pnpm run wasm:build && vite",
"build": "pnpm run wasm:build && tsc && vite build",
"preview": "vite preview",
"wasm:build": "cd ../shared && wasm-pack build --target web"
}
<> | ||
<h1>Vite + Solid</h1> | ||
<div class="card"> | ||
<button>count is {view.getView().text}</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<button>{view.getView().count}</button>
When I tested it, there was no styling. Any chance you could bring that in too? Thank you! |
Thanks for the review ! |
9a0821b
to
811bb4c
Compare
811bb4c
to
1551f58
Compare
I've done those changes you needed:
Let me know if it looks better now (whenever you've got the time, no rush) |
Hey @nmrshll this looks great now! Thank you for contributing. There's just a couple of minor things. The first is that we'll need a The second is that the import initCore from "shared";
await initCore(); Other than that would be happy to merge. Thank you. |
closes #172