Add test showing Reagent running disposed reactions #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcompton
force-pushed
the
running-disposed-reactions
branch
from
3a761a4
to
ed4d313
Compare
danielcompton
force-pushed
the
running-disposed-reactions
branch
from
ed4d313
to
133d4c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing day8/re-frame#259 we noticed that Reagent was happily running reactions that had been disposed of. This commit adds a failing test exposing that behaviour. I'm not sure exactly what the right behaviour is here, but I don't think Reagent should silently allow this.