Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename run! macro to react! #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

darwin
Copy link

@darwin darwin commented Jun 25, 2015

under [org.clojure/clojurescript "0.0-3308"]
it was shadowing clojure.core/run! and causing warning:

WARNING: run! already refers to: #'clojure.core/run! in namespace: reagent.ratom, being replaced by: #'reagent.ratom/run!

@mike-thompson-day8
Copy link
Member

See also #125

@darwin
Copy link
Author

darwin commented Jun 26, 2015

Thanks for the link.

AFAIK the problem with :refer-clojure is that it would have to be written in every file including ratom macros.

Also I think that run! name is unfortunate. It implies something which is run once and has side-effects. We need some better name which hints "this piece of code is being run multiple times in reaction to ratom changes".

@danielcompton
Copy link
Contributor

If we're going to go down this track, it would be good to go through a depreciation process for this. run! should still be usable for at least one more minor version series to let people update their code gracefully, and deprecation warnings should be printed when people use run!.

under [org.clojure/clojurescript "0.0-3308"]
it was shadowing clojure.core/run! and causing warning:
WARNING: run! already refers to: #'clojure.core/run! in namespace: reagent.ratom, being replaced by: #'reagent.ratom/run!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants