-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with react.dev @ 4c91abc7 #56
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: OH HYUN KEUN <[email protected]>
This upstreams some of the [introduction post](reactwg/react-compiler#5) into the docs since this knowledge is quite fundamental to understanding the compiler, and it's confusing to not have it linked in the canonical source for the docs. It also adds more information about [debugging](reactwg/react-compiler#7) and reorganizes a few sections to make things clearer ghstack-source-id: ef32fc723722eb5119529abcc572dd2bcf2b1cab Pull Request resolved: reactjs/react.dev#6895
* Add React Conf 2024 Recap post * Spelling and links * Apply suggestions from code review Co-authored-by: lauren <[email protected]> * Edits * Edits * better link * Update date * Update date and nits * feedback --------- Co-authored-by: lauren <[email protected]>
* Add codemods to upgrade guide * Update src/content/blog/2024/04/25/react-19-upgrade-guide.md Co-authored-by: Ahmed Abdelbaset <[email protected]> * Add benefits --------- Co-authored-by: Ahmed Abdelbaset <[email protected]>
The docs for stylesheet precedence incorrectly state that there is an enumerated set of valid precedences. This is incorrect. The precedence value can be anything and React infers the hierarchy from the order in which it discovers precedences
* FIX: Typo in useEffect.md caveats * Fix another typo
* Add act documentation * Update structure based on feedback * Add usage examples and async act --------- Co-authored-by: Rick Hanlon <[email protected]>
Fix very minor typo
Added missing comma to the codesample.
Expo now has its own instructions for enabling the compiler.
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
Page | Size (compressed) |
---|---|
global |
104.19 KB (🟡 +44 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
Five Pages Changed Size
The following pages changed size from the code in this PR compared to its base branch:
Page | Size (compressed) | First Load |
---|---|---|
/404 |
104.28 KB (🔴 +23.16 KB) |
208.47 KB |
/500 |
104.27 KB (🔴 +23.16 KB) |
208.46 KB |
/[[...markdownPath]] |
106.12 KB (🔴 +23.16 KB) |
210.31 KB |
/errors |
104.48 KB (🔴 +23.16 KB) |
208.68 KB |
/errors/[errorCode] |
104.46 KB (🔴 +23.16 KB) |
208.66 KB |
Details
Only the gzipped size is provided here based on an expert tip.
First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link
is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.
Any third party scripts you have added directly to your app using the <script>
tag are not accounted for in this analysis
Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.
This PR was automatically generated.
Merge changes from react.dev at 4c91abc
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.