-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync with react.dev @ b7bf6c16 #48
Open
react-translations-bot
wants to merge
305
commits into
main
Choose a base branch
from
sync-b7bf6c16
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update 17 files * remove: legacy react devtool * Update 3 files * fix(editor): allow horizontal scroll * Update SandpackRoot.tsx
corrected links
…llback doesn't seem to be accurate. (#6207) * Update useEffect.md * Update src/content/reference/react/useEffect.md --------- Co-authored-by: Sophie Alpert <[email protected]>
* delete unused useState import * add word to equalize challenge and solutions texts * Refactor some texts * Apply suggestions from code review --------- Co-authored-by: Sophie Alpert <[email protected]>
* Remove pitfall and update Next link * Fix other beta link --------- Co-authored-by: Luna Wei <[email protected]>
Co-authored-by: Luna <[email protected]>
* Update react-labs-what-we-have-been-working-on-june-2022.md * Update react-labs-what-we-have-been-working-on-june-2022.md
…5836) * Update referencing-values-with-refs.md * Update src/content/learn/referencing-values-with-refs.md
Maybe it's debatable whether we want to link to canary APIs in other pages but I feel like here it's more useful than not.
Co-authored-by: Matt Carroll <[email protected]>
* Explain limitations of useSyncExternalStore with concurrency Doesn't seem like we have this noted anywhere. * Pull out example to code block
* Add versions page and nav version * Move version to siteConfig.js * Fix typo * Set to 18.3.1, use siteConfig in reference sidebar * Redirect 18.react.dev to react.dev for now * Fix stray bullet
* Update typescript.md Fix punctuation. * Update src/content/learn/typescript.md --------- Co-authored-by: Ricky <[email protected]>
* Try next/image * Fix styles.css * rm unneeded styles * priority=true * tweaks * Static height * tweak * priority
Typo Node => Note
* Add new article "Translations" * Add "languages" button in TopNav * Add link to English (main) site * Split deployedTranslations into multiple lines * Fix build error regarding types * Address some review comments - deployedTranslations => finishedTranslations - showTranslated => progress - English fixes * Update src/content/community/translations.md Co-authored-by: Ricky <[email protected]> * Update src/content/community/translations.md --------- Co-authored-by: Ricky <[email protected]>
Thanks to @SAWARATSUKI for updating the logo!
Change the tense of "build" to "building".
* Update synchronizing-with-effects.md Currently documentation says: By default, your Effect will run after every render. Which is in contrast with another section of the same page where it says: Effects run at the end of a commit after the screen updates * Update src/content/learn/synchronizing-with-effects.md --------- Co-authored-by: Ricky <[email protected]>
* Fix #6854: node.js version upgrade * Fix #6854: node.js version update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from react.dev at b7bf6c1
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from main and cause them to show up as conflicts the next time we merge.