-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add test build type for android_build #150
base: main
Are you sure you want to change the base?
feat: add test build type for android_build #150
Conversation
Could you make an example on why this is needed @matinzd ? |
In some react native projects there are different types of flavors are configured for the project based on the needs, but test flavors are not configured or they have different test build type. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but test flavors are not configured or they have different test build type.
I don't have a strong opinion on this. It feels a bit unnecessary to me, but I believe there could be scenarios where this is useful for some.
We can merge this imho. The problem is that I believe the token expired so CircleCI is red at the moment. I'm unsure who can help us here
dc60eab
to
ee8a478
Compare
@matinzd now that the CI/CD pipeline has been fixed, this needs a rebase. @cortinico if this is still useful feel free to merge. 🚀 |
ee8a478
to
6645ae5
Compare
I don't have a strong opinion here. We're not using this orb internally and I'll leave the decision to merge to you folks |
6645ae5
to
f1bd0ba
Compare
f1bd0ba
to
a9e36e6
Compare
Add
test_build_type
to build_android job and command.