-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note which settings pertain only to the bootloader... #3038
Changes from 6 commits
848a1c9
1f914e6
3a5f980
3643882
fea6b23
c0055ff
a8db339
d6900bb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,21 @@ Causes the content of the specified file to be inserted into the current file. | |
|
||
For example, adding the line `include extraconfig.txt` to `config.txt` will include the content of `extraconfig.txt` file in the `config.txt` file. | ||
|
||
*Include directives are not supported by bootcode.bin or the EEPROM bootloader* | ||
[NOTE] | ||
==== | ||
|
||
*Include directives are not supported by the bootcode.bin or EEPROM bootloaders*. | ||
|
||
Settings which are handled by the bootloader and so which will only take effect if they are specified in `config.txt` (rather than any additional included file) are: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd be happy to keep this bit where you document which settings don't work when used in an included file, as I suspect only a very small proportion of users actually use config.txt includes. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think a small note block about include files is okay. NOTES per individual items, not so much. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
d6900bb removes the individual NOTEs. |
||
|
||
* `bootcode_delay`, | ||
* `gpu_mem`, `gpu_mem_256`, `gpu_mem_512`, `gpu_mem_1024`, | ||
* `total_mem`, | ||
* `sdram_freq`, | ||
* `start_x`, `start_debug`, `start_file`, `fixup_file`, | ||
* `uart_2ndstage`. | ||
|
||
==== | ||
|
||
==== Conditional Filtering | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without any other context, I think these standalone NOTEs saying "only valid in
config.txt
" would be too confusing, given that they all appear on https://www.raspberrypi.com/documentation/computers/config_txt.html which is titled "The config.txt file".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess a link could be added to the section discussing includes - or does it just need to be made more specific by changing the end of the line to something along the lines of "… and so are not allowed in any additional
include
d configuration file"?The aim here is to avoid the confusion of including a file with these settings in, and then finding that they've not taken effect! 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it likely that anybody who's using
config.txt
includes will have read the section about config.txt include files, and so will have seen the list of settings that don't work in an included file? I'm reluctant to "pollute" the rest of the config.txt documentation with (potentially confusing) information that's only of benefit to a small proportion of users.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page is called "config.txt" makes no sense to add notes like this, adds confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d6900bb removes the individual NOTEs.