Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1 of Landing Page & FAQ - Rails World 2024 #247

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

john-farina
Copy link
Contributor

@john-farina john-farina commented Apr 1, 2024

Info

This PR is adding the Landing Page and FAQ for the upcoming Rails World event.

Images

Landing page

SCR-20240401-qppf SCR-20240401-qpqy

FAQ

SCR-20240401-qpsq

Future releases

  • Speaker pages
  • Sponsors
  • & More

Comment on lines -57 to -58
sass:
style: compressed
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is here - isn't this the same as the base branch?

@john-farina john-farina marked this pull request as ready for review April 1, 2024 22:41
@AmandaPerino AmandaPerino merged commit 99d0452 into rails:main Apr 1, 2024
1 check failed
@AmandaPerino AmandaPerino mentioned this pull request Apr 1, 2024
@ramzieus
Copy link

ramzieus commented Apr 2, 2024

hi @john-farina check this issue #254

@ramzieus
Copy link

ramzieus commented Apr 2, 2024

You can analyse the page using Chrome Lighthouse then fix the issue to get all things 100%.

Screenshot_20240402_234135
this is actually what the page showing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants