-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please don't use the qurator namespace #112
Comments
It's possible that the installation of eynollah does not conflict with sbb_binarization anymore, but with other qurator software (page2tsv etc.). I'll check. |
Installing eynollah and sbb_binarization (both main/master) into one Python 3.9 venv does not cause immediately visible breakage. I can call both tools' CLIs'
Installing sbb_tools (master again) into the same venv also does not cause breakage with e.g. What I did NOT test: What I am STILL saying: I don't think I have anything else to contribute here. |
Ah, I see, this is because the revert by @bertsky is in main already. And there's not a problem in sbb_binarization anymore. So this needs more investigation. TODO:
|
Just a brief sidenote fyi - as of Eynollah 0.3.0, the model used by it for binarization is identical to the one of https://github.com/qurator-spk/sbb_binarization. As one of the next steps, binarization will be exposed as an invididual processing step in Eynollah, and eventually we will deprecate the separate https://github.com/qurator-spk/sbb_binarization project. |
Apparently there is still a namespace problem when installing e.g. eynollah and sbb_binarization together and I think it should be resolved by not using "qurator" as part of the namespace (move "eynollah/" one level down and fix all references accordingly)
I've checked sbb_binarization and I don't think it should not conflict anymore but I'll check tomorrow to make sure. (@bertsky reported this in #106)
❗ However IF it still is a problem, then this is a serious bug that needs to be fixed ASAP
The text was updated successfully, but these errors were encountered: