Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please don't use the qurator namespace #112

Open
mikegerber opened this issue Aug 15, 2023 · 4 comments
Open

Please don't use the qurator namespace #112

mikegerber opened this issue Aug 15, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@mikegerber
Copy link
Member

Apparently there is still a namespace problem when installing e.g. eynollah and sbb_binarization together and I think it should be resolved by not using "qurator" as part of the namespace (move "eynollah/" one level down and fix all references accordingly)

I've checked sbb_binarization and I don't think it should not conflict anymore but I'll check tomorrow to make sure. (@bertsky reported this in #106)

❗ However IF it still is a problem, then this is a serious bug that needs to be fixed ASAP

@mikegerber mikegerber added the bug Something isn't working label Aug 15, 2023
@mikegerber mikegerber self-assigned this Aug 15, 2023
@mikegerber mikegerber changed the title ❗ Please don't use the qurator namespace Please don't use the qurator namespace Aug 15, 2023
@mikegerber mikegerber removed their assignment Aug 15, 2023
@mikegerber
Copy link
Member Author

It's possible that the installation of eynollah does not conflict with sbb_binarization anymore, but with other qurator software (page2tsv etc.). I'll check.

@mikegerber
Copy link
Member Author

Installing eynollah and sbb_binarization (both main/master) into one Python 3.9 venv does not cause immediately visible breakage. I can call both tools' CLIs' --help:

Call result
eynollah --help works
ocrd-eynollah-segment --help works
sbb-binarize --help works
ocrd-sbb-binarize --help works

Installing sbb_tools (master again) into the same venv also does not cause breakage with e.g. altotool --help, it seems. So I am somewhat questioning if there is still a problem but as didn't test the released versions this could happen for those.

What I did NOT test:
@bertsky mentioned installing in devel mode, and I didn't install it devel mode. This might be relevant in a way I don't see now. (I am also not recommending doing it, but that's not the point.)

What I am STILL saying:
Using the qurator namespace should be avoided. Not sharing a namespace makes life easier.

I don't think I have anything else to contribute here.

@mikegerber
Copy link
Member Author

Ah, I see, this is because the revert by @bertsky is in main already. And there's not a problem in sbb_binarization anymore.

So this needs more investigation.

TODO:

  • revert the revert
  • test again with sbb_tools
  • verify that sbb_binarization really has no problem anymore.

@cneud
Copy link
Member

cneud commented Aug 17, 2023

Just a brief sidenote fyi - as of Eynollah 0.3.0, the model used by it for binarization is identical to the one of https://github.com/qurator-spk/sbb_binarization. As one of the next steps, binarization will be exposed as an invididual processing step in Eynollah, and eventually we will deprecate the separate https://github.com/qurator-spk/sbb_binarization project.

@cneud cneud added enhancement New feature or request and removed bug Something isn't working labels Aug 17, 2023
@kba kba mentioned this issue Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants