[Keyboard] Add Marcopad #24636
Open
[Keyboard] Add Marcopad #24636
+176
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
requested changes
Nov 23, 2024
keyboards/marcopad/keyboard.json
Outdated
Comment on lines
9
to
13
| "command": false, | ||
| "console": false, | ||
| "extrakey": false, | ||
| "mousekey": false, | ||
| "nkro": false |
There was a problem hiding this comment.
Suggested change
| "command": false, | |
| "console": false, | |
| "extrakey": false, | |
| "mousekey": false, | |
| "nkro": false | |
| "extrakey": true, | |
| "mousekey": true, | |
| "rgblight": true |
Comment on lines
22
to
26
|
|
||
| const uint16_t PROGMEM backlight_combo[] = {KC_P7, KC_P8, COMBO_END}; | ||
| combo_t key_combos[] = { | ||
| COMBO(backlight_combo, UG_NEXT) | ||
| }; |
There was a problem hiding this comment.
- default keymaps should be "pristine"
- what does pristine mean? no custom keycodes. no advanced features like tap dance or macros
Suggested change
| const uint16_t PROGMEM backlight_combo[] = {KC_P7, KC_P8, COMBO_END}; | |
| combo_t key_combos[] = { | |
| COMBO(backlight_combo, UG_NEXT) | |
| }; |
dunk2k
suggested changes
Nov 23, 2024
marcopelegrini
force-pushed
the
users/mpelegrini/Marcopad
branch
from
825b52e
to
72dda14
Compare
dunk2k
suggested changes
Nov 24, 2024
keyboards/marcopad/keyboard.json
Outdated
| "diode_direction": "ROW2COL", | ||
| "features": { | ||
| "bootmagic": true, | ||
| "rgblight": false |
There was a problem hiding this comment.
Rgblight feature is disabled by default
Suggested change
| "rgblight": false |
marcopelegrini
force-pushed
the
users/mpelegrini/Marcopad
branch
from
565371f
to
73fea49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Marcopad
Types of Changes
Issues Fixed or Closed by This PR
Checklist