Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmk new-keyboard: prompt for matrix type and dimensions #24634

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 23, 2024

Description

When running qmk new-keyboard, ask the user what their matrix setup will be (col2row, row2col, direct, or custom), and do some simple validation of the dimensions based on the layout they've chosen. Pins are still placeholders; the process could be extended to prompt for each but that might be a little too unwieldy...

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 23, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant