Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Binepad BNK8 keyboard #24598

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Keyboard] Add Binepad BNK8 keyboard #24598

wants to merge 4 commits into from
+161 −0

Conversation

vinorodrigues
Copy link
Contributor

Description

Add Binepad BNK8 keyboard - a 3x3 macropad with rotary encoder.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

(n/a)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

dunk2k
dunk2k suggested changes Nov 13, 2024
View reviewed changes
keyboards/binepad/bnk8/keyboard.json Outdated Show resolved Hide resolved
@waffle87 waffle87 requested a review from a team November 15, 2024 03:16
fauxpark
fauxpark requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGB_ -> RM_ keycodes after this round of breaking changes.

keyboards/binepad/bnk8/keymaps/default/keymap.json Outdated Show resolved Hide resolved
keyboards/binepad/bnk8/keymaps/default/keymap.json Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinorodrigues @fauxpark @waffle87 @dunk2k