Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kiiboom loop65 #23560

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

KiiBOOM-Official
Copy link

@KiiBOOM-Official KiiBOOM-Official commented Apr 19, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 19, 2024
@waffle87
Copy link
Member

This appears to be exactly the same keyboard as epomaker/tide65? (#23356)

diff loop65/info.json epomaker/tide65/info.json
3c3
<     "keyboard_name": "KIIBOOM LOOP 65",
---
>     "keyboard_name": "EPOMAKER TIDE 65",
Common subdirectories: loop65/keymaps and epomaker/tide65/keymaps
Only in loop65: loop65.c
diff loop65/readme.md epomaker/tide65/readme.md
1c1
< # KIIBOOM LOOP 65
---
> # EPOMAKER TIDE 65
4,5c4,5
< * Hardware Supported: KIIBOOM LOOP 65
< * Hardware Availability: [kiiboom](https://www.kiiboom.com)
---
> * Hardware Supported: EPOMAKER TIDE 65
> * Hardware Availability: [epomaker](https://www.epomaker.com)
9c9
<     make kiiboom/loop65:default
---
>     make epomaker/tide_65:default
13c13
<     make kiiboom/loop65:default:flash
---
>     make epomaker/tide65:default:flash
Only in epomaker/tide65: tide65.c

@KiiBOOM-Official
Copy link
Author

This appears to be exactly the same keyboard as epomaker/tide65? (#23356)

diff loop65/info.json epomaker/tide65/info.json
3c3
<     "keyboard_name": "KIIBOOM LOOP 65",
---
>     "keyboard_name": "EPOMAKER TIDE 65",
Common subdirectories: loop65/keymaps and epomaker/tide65/keymaps
Only in loop65: loop65.c
diff loop65/readme.md epomaker/tide65/readme.md
1c1
< # KIIBOOM LOOP 65
---
> # EPOMAKER TIDE 65
4,5c4,5
< * Hardware Supported: KIIBOOM LOOP 65
< * Hardware Availability: [kiiboom](https://www.kiiboom.com)
---
> * Hardware Supported: EPOMAKER TIDE 65
> * Hardware Availability: [epomaker](https://www.epomaker.com)
9c9
<     make kiiboom/loop65:default
---
>     make epomaker/tide_65:default
13c13
<     make kiiboom/loop65:default:flash
---
>     make epomaker/tide65:default:flash
Only in epomaker/tide65: tide65.c

I understand that you require clarification regarding the nature of my submission. To confirm, the provided code pertains to the QMK configuration for two distinct keyboard models. Please inform me if this submission violates any guidelines or policies. Thank you for your attention to this matter.

@waffle87
Copy link
Member

As far the firmware is concerned, they are not distinct keyboards at all, which may not violate any policies per se, but that doesn't mean there are no issues. For example, can you explain the need for the code in keyboards/kiiboom/loop65/loop65.c? Another thing, these keyboards share the exact same VID/PID, which will likely cause issues with things like VIA. The list can go on.

@tzarc tzarc marked this pull request as draft May 16, 2024 04:36
@tzarc
Copy link
Member

tzarc commented May 16, 2024

If this is identical to a tide65, then it's a trimode board. On hold until we find out if that's the case.

@tzarc
Copy link
Member

tzarc commented Jul 10, 2024

This PR is on hold until #24085 is rectified.

@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid keyboard keymap needs-wireless-code via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants