Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Python 3.7 #53

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Drop support for Python 3.7 #53

merged 2 commits into from
Dec 5, 2023

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Dec 3, 2023 •
edited
Loading

Also:

  • Drop some tests for Python 3.6.
  • Add Python 3.12 to the test matrix.

@ccordoba12 ccordoba12 added this to the v2.0.0 milestone Dec 3, 2023
@ccordoba12 ccordoba12 self-assigned this Dec 3, 2023
@ccordoba12
Drop support for Python 3.7
d905906 
Also, drop some tests for Python 3.6
@ccordoba12 ccordoba12 requested a review from haplo December 3, 2023 17:43
haplo
haplo reviewed Dec 3, 2023
View reviewed changes
pyproject.toml
@@ -1,5 +1,5 @@
[tool.black]
target-version = ['py36', 'py37', 'py38', 'py39', 'py310']
target-version = ['py38', 'py39', 'py310', 'py311']
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't py312 be here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that but it seems Black doesn't recognize it as a valid version yet because tests fail due to that.

@ccordoba12
Copy link
Member Author

@haplo, are you ok with merging this one?

haplo
haplo approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@haplo haplo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ccordoba12 ccordoba12 merged commit 007172c into python-lsp:master Dec 5, 2023
5 checks passed
@ccordoba12 ccordoba12 deleted the drop-py37 branch December 5, 2023 12:24
@ccordoba12 ccordoba12 mentioned this pull request Dec 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haplo haplo haplo approved these changes

Assignees

@ccordoba12 ccordoba12

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ccordoba12 @haplo