No virtual modules & No scoped loops for unknown collectors. #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c package-scoped fixtures. The temporary files used for this mechanism appearing as disappear after they have been collected. This seems to create issues in some projects, such as setuptools. see pytest-dev#729 (comment) Signed-off-by: Michael Seifert <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 94.78% 94.37% -0.42%
==========================================
Files 2 2
Lines 499 480 -19
Branches 99 97 -2
==========================================
- Hits 473 453 -20
Misses 19 19
- Partials 7 8 +1 ☔ View full report in Codecov by Sentry. |
|
Fixes #729 |
…lector types. Signed-off-by: Michael Seifert <[email protected]>
seifertm
force-pushed
the
no-virtual-modules
branch
from
0f18a45
to
d437496
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way package-scoped fixtures are registered. Pytest-asyncio no longer creates temporary Python modules (aka "virtual modules") with fixture definitions during collection time. Some setups seem to rely on a fixed list of collected files (see #729 (comment)).
This PR also limits the impact of pytest-asyncio's collection changes for scoped event loops. The plugin no longer tries to install scoped event loops in unknown collector types.