Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Litmus from Gemfile #84

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

mhashizume
Copy link
Contributor

We do not use Litmus for tests and its dependencies are causing issues in our CI pipeline. This commit removes Litmus from the Gemfile.

We do not use Litmus for tests and its dependencies are causing issues
in our CI pipeline. This commit removes Litmus from the Gemfile.
@mhashizume mhashizume requested a review from a team as a code owner November 19, 2024 20:23
@mhashizume
Copy link
Contributor Author

I ran these changes through the ad hoc pipelines and it resolved the issues we've been seeing: https://jenkins-platform.delivery.puppetlabs.net/view/modules/view/Core/view/augeas_core/view/adhoc/

It does not appear that PDK provides a way to delete a gem like puppet_litmus that's included in the default PDK template, so we'll have to be careful in the future when running pdk update on this module.

@mhashizume mhashizume added the maintenance Maintenance chores are typically excluded from changelogs label Nov 19, 2024
@joshcooper joshcooper merged commit d97740d into puppetlabs:main Nov 20, 2024
14 checks passed
@mhashizume mhashizume deleted the PA-7115/main/litmus_removal branch November 25, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are typically excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants