-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(registry): Add pgEdge provider package #6023
base: master
Are you sure you want to change the base?
Conversation
added basic layout with go,typescript examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KnockOutEZ, thanks for opening a PR and writing such great docs. We will need to make a couple of changes before merging.
tools/resourcedocsgen/pkg/lookup.go
Outdated
@@ -189,6 +190,7 @@ var TitleLookup = map[string]string{ | |||
"opsgenie": "Opsgenie", | |||
"packet": "Packet", | |||
"pagerduty": "PagerDuty", | |||
"pgedge": "pgEdge", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TitleLookup
is being deprecated in favor of the "displayName"
field in the provider schema. If you set tfbridge.ProviderInfo.DisplayName
, then it will flow through.
We are not adding new packages to lookup.go
.
tools/resourcedocsgen/pkg/lookup.go
Outdated
@@ -92,6 +92,7 @@ var CategoryLookup = map[string]PackageCategory{ | |||
"openstack": PackageCategoryCloud, | |||
"opsgenie": PackageCategoryInfrastructure, | |||
"pagerduty": PackageCategoryInfrastructure, | |||
"pgedge": PackageCategoryDatabase, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of setting this in the override map, please just set catagory/database
in your schemas "keywords"
section with tfbridge.ProviderInfo.Keywords
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is auto-generated, and will be added automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs files are pulled from your repo. This file should live at github.com/pgedge/pulumi-pgedge/docs/_index.md
. The registry will pick it up during builds.
This way the docs are:
- Versioned with your provider.
- Editable by you without going through our PR process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs files are pulled from your repo. This file should live at github.com/pgedge/pulumi-pgedge/docs/installation-configuration.md. The registry will pick it up during builds.
community-packages/package-list.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the only change we need here.
Thanks for the feedbacks @iwahbe . I just fixed the PR items and also updated the pulumi-pgedge repo. |
Thanks for the contribution @KnockOutEZ. A few questions:
|
Description
This PR adds the pgEdge provider package to the Pulumi Registry. The pgEdge provider enables management of pgEdge Cloud resources, supporting both Developer and Enterprise editions. This provider allows users to manage databases, clusters, backup stores, and cloud accounts through Pulumi infrastructure as code.
Adding a new package?
If this pull request adds a new package:
provider/cmd/pulumi-resource-pgedge/schema.json
).Database
)./docs/_index.md
) that includes:package
./docs/installation-configuration.md
) that includes:PGEDGE_CLIENT_ID
andPGEDGE_CLIENT_SECRET
).Additional Notes: