Replace pulumi-java-gen with pulumi package gen-sdk #3151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
blampe
added
the
impact/no-changelog-required
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3151 +/- ##
==========================================
- Coverage 36.32% 36.27% -0.05%
==========================================
Files 70 70
Lines 9251 9256 +5
==========================================
- Hits 3360 3358 -2
- Misses 5555 5561 +6
- Partials 336 337 +1 ☔ View full report in Codecov by Sentry. |
Frassle
force-pushed
the
fraser/javagen
branch
2 times, most recently
from
3866816
to
466104d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP
This replaces the use of
pulumi-java-genwithpulumi package gen-sdk, the new and modern interface to codegen.gen-sdkdoes make some assumptions about overlay and output paths containing the language name, so I've had to move everything inprovider/pkg/gen/java-templatesdown one level into a nestedjavadirectory (alternatively we could have renamedjava-templatesto justjava).Also without the
--buildoption to use on the command line we need to set the gradle-nexus options directly in the schema.Finally java sdk gen doesn't set its own default dependencies, it was only the pulumi-java-gen command that filled in defaults correctly. That feels like a java codegen bug that should be fixed before we merge this so we don't have to add all the default dependencies in the schema directly (the PR currently does this).