Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some computed properties as optional #1059

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Mark some computed properties as optional #1059

wants to merge 2 commits into from

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Apr 8, 2024

Refs pulumi/pulumi-terraform-bridge#1239 (comment)

This is a breaking change to the SDK, so I'm conflicted on whether this is a reasonable fix. It would be helpful to hear from users impacted by this behavior.

The only situation where the breakage could by justified IMO is if the resource is essentially unusable without this fix. If some users are already using the resource without issue, then I think we'll need to find a different way to handle this without breaking them.

Fixes #1052

Copy link

github-actions bot commented Apr 8, 2024

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 2 breaking changes:

Resources

  • "docker:index/container:Container": required:
    • 🟢 "containerLogs" property is no longer Required
    • 🟢 "healthcheck" property is no longer Required
      No new resources/functions.

Maintainer note: consult the runbook for dealing with any breaking changes.

Copy link

github-actions bot commented Apr 8, 2024

Is README.md missing any configuration options?

caMaterial not found in Configuration section
certMaterial not found in Configuration section
certPath not found in Configuration section
host not found in Configuration section
keyMaterial not found in Configuration section
registryAuth not found in Configuration section
sshOpts not found in Configuration section

Please add a description for each of these options to README.md. Details about them can be found in either the upstream docs or schema.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field containerLogs in docker:index/container:Container is incorrectly set as required
1 participant