Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output-ify JSON use in CreateRoleStack #1325

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Output-ify JSON use in CreateRoleStack #1325

wants to merge 1 commit into from

Conversation

Frassle
Copy link
Member

@Frassle Frassle commented Dec 16, 2022

No description provided.

@justinvp justinvp mentioned this pull request Feb 6, 2023
Open
31 tasks
dixler
dixler approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@dixler dixler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything keeping us from merging this?

@scottslowe
Copy link
Contributor

Given that it looks like all the AWS tests failed, it seems like we should maybe re-run the tests before merging?

@Frassle
Copy link
Member Author

Frassle commented Mar 22, 2023

Anything keeping us from merging this?

I haven't checked this actually works...

@lukehoban lukehoban mentioned this pull request Mar 27, 2023
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dixler dixler dixler approved these changes

@justinvp justinvp justinvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Frassle @scottslowe @justinvp @dixler