-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: debug and verbosity #1046
base: main
Are you sure you want to change the base?
Conversation
Hey @arthurderyckere-newday , thanks for the reply! Solved the conflict. Should be good to go |
log-to-std-err: | ||
description: 'Log to stderr instead of to files' | ||
required: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any value in logging to files inside the action? Unless users have setup to trawl /tmp at the end of the job their just going to get lost? Wonder if this be flipped relative to automationapi and be "log-to-files" and default to logging to stderr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekbduffy would you consider settling for log-verbose and debug options and revisit this log-to-std-err at a later stage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup the others make sense, just --log-to-stderr should probably default on if either of the others are set.
Adding two optional inputs that are already supported by @pulumi/automation
fixes: #589
Unfortunately there's no functionality in @pulumi/automation supporting args passing.