Fix CI test runner #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably worth removing the 3.7 trove classifier |
|
Good callout, we'll do that as part of dropping support in the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves us off the tox runner to use
pytestdirectly. We can also set up the support matrix to pass a-eparameter to tox to only invoke the correct environment, but that's a bit more involved. This PR will get the CI suite running correctly again so we can resolve #51. If someone is opinionated on keeping tox in the CI suite, we can address that in a follow up PR.This also removed Python 3.7 from our support matrix since there is no longer a supported test runner in
actions/setup-python.