Allow redis to set expires with an int arg #269
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like there are at least a couple scenarios in
controller.py
where the expires can be an int instead of a datetime.https://github.com/ionrock/cachecontrol/blob/3bd694551d28445723c18f4ad8c44bce55ff9b5f/cachecontrol/controller.py#L325
https://github.com/ionrock/cachecontrol/blob/3bd694551d28445723c18f4ad8c44bce55ff9b5f/cachecontrol/controller.py#L349
With the way that works currently, I think some check needs to be done in
RedisCache
to see what type we're working with... the other solution that comes to mind is thatexpires
should only be an int or a datetime? That would be a more involved change but I'd be willing to put some time into it @ionrock if you prefer it goes that direction. Implementing mypy or something might help sort out that kind of bug.Fixes #268