Add bdm hdd support #1365
Add bdm hdd support #1365
Conversation
|
Got a test binary? |
CI builds pending prs if you ever want to try them before merge https://github.com/ps2homebrew/Open-PS2-Loader/actions/runs/11513539409 |
src/bdmsupport.c
Outdated
| else { | ||
| dmaType = 0x40; | ||
| #ifdef ATA_UDMA_PLUS | ||
| dmaMode = pDeviceData->ataHighestUDMAMode; |
There was a problem hiding this comment.
Chinese IDE-to-SD adapters are faking this value in adapter specs. If the user still can set UDMA mode manually it is ok, but I am not sure if settings for "classic" HDD (HD Loader) will be taken in place in this case. Also some adapters sets this value to zero, while actually supports UDMA4.
There was a problem hiding this comment.
I'm not sure what to do here about that? Any suggestions?
There was a problem hiding this comment.
Huh, I am not sure too, maybe read udma mode from HDD apa settings somehow?
There was a problem hiding this comment.
but that's what it's doing already? on device connection it calls the cmd to retrieve the highest udma mode here
Open-PS2-Loader/src/bdmsupport.c
Line 765 in 723dedd
Open-PS2-Loader/modules/hdd/xhdd/xhdd.c
Line 58 in 723dedd
and store the value in pDeviceData->ataHighestUDMAMode then at launch its just applying it in this line we're quoting.
Or I'm just misunderstanding your latest comment and you mean read a manually defined udma user setting?
There was a problem hiding this comment.
Huh, I am not sure too, maybe read udma mode from HDD apa settings somehow?
Oh wait apa settings.. I didn’t read this properly.. what about this? If ataHighestUDMAMode > 0 use it, otherwise use the user defined setting from the cfg?
There was a problem hiding this comment.
Yes, I was talking about user defined value that are per game.
There was a problem hiding this comment.
Yes, I was talking about user defined value that are per game.
ok now it works very similar to apa hdd, if the automatically resolved udma is <= 0 it will use the user defined value.. we could have it always use the user defined value but then the whole ataHighestUDMAMode is pointless and unused..
so now we check ataHighestUDMAMode is greater than 0 if its not due to a faked value we use the user defined value
|
I've been testing the CI build and I've found a couple of bugs.
I tried to compile this PR with the latest build and bdm hdd support doesn't work at all. I did a little debugging on KrahJohlito's gd2 build trying to find the issue with 'autoLaunchBDMGame'. It gets as far as reading the game's config file from the exFAT partition on the HDD but then just crashed when trying to launch the game. |
2 is likely not “completely broken” but broken for hdd as I forgot to add the loading of bdm hdd modules for auto launching, that’s probably all it is Edit: ok now I'm actually on pc, no its more than that haha i'll try push an update if you can give it a quick test |
I can test it whenever you're ready :) |
I think both issues 1 & 2 should work properly now.. tbh the whole cfg saving/loading system needs a rewrite (probably a more static approach like maximus32 has suggested multiple times is the best way to go) but I personally don't have time to it at the moment. I'll rebase if those problems are solved. |
OPL settings now save to memory card and are loaded at launch however, OPL always starts up on the menu instead of the games list. BDM Auto Launch didn't working on HDD or USB but I did some debugging. opl.c line 1846, change the delay to 10 and it works! |
I’m going to drop the cfg changes commit, the whole system is the problem and needs a rewrite.. the cfg entry to know whether or not to load the module is in the cfg.. but how can we read it from the cfg if the module isn’t loaded :-s .. chicken and the egg situation. ok so we gotta increase the delay now thanks for trying it, I’ll try make it more dynamic so it’s not just a set x delay, we’ll just delay as long as we need to until the device is found that way it’s not longer than it needs to be. |
|
@CosmicScale I've just set a delay loop if you're free to test the auto launching again? The cfg issues will need to be addressed in a separate pull request imo as a rewrite to the system will require some big changes. |
The new loop with delay(2) fixed loading from HDD but USB was still broken. I experimented with delay lengths, the shortest delay that reliably worked with both was 6. |
|
force pushed |
|
I could not get this to run i just get a black screen |
Working perfectly for me. Could be the way you formatted your drive. I assume, just like Grimdoomer's build, the HDD must have a sector size of 512. I remember people have issues when using certain USB enclosures. It's best to connect the HDD directly to your PC then format it. |
i was talking about opl not even launching its in a boot loop and if unplug the hard drive opl works i just reformatted me drive and made sure it was 512 and its still doing it |
Try deleting your OPL config files. |
likely due to this #1380 which imo is from a ps2sdk update, if you tried the latest version of this build; I rebased which used a newer sdk to compile.. try this one before that sdk update and see if the issue persists https://github.com/ps2homebrew/Open-PS2-Loader/actions/runs/11694352998 .. after the recent sdk update I get random spam messages in pcsx2 logs |
Yep its working now |
|
Happy to help test this. 8TB HDD exFAT. Grimdoomer's build works. The current PR build switches to GPT and then is quite laggy. Loader icon just keeps spinning and inputs are don't register unless on a specific frame |
KrahJohlito
force-pushed
the
gd2
branch
3 times, most recently
from
cd1e675
to
c300a02
Compare
Hello! I tested this build too. And I found that loading the HDD game list is too slow,but Grimdoomer's build works good. |
Hi guys, unfortunately these differences appear to be the result of a newer build environment because the code here is almost exactly the same as grimdoomer builds (can’t really do anything about that in this pr, may need to be addressed in the sdk idk). https://github.com/KrahJohlito/Open-PS2-Loader/actions/runs/11811553194 This version that I’m linking above is the same as this PR build except the build environment used is very similar to OPL revision 2049 rather than “latest” and seems to have much better performance; conclusion this PR is not causing the issues but there can still be improvements made whether it be in the build environment or OPL itself. I do not intended to try rectify any further issues in this PR (with the exception of current pending reviews) as I don’t believe the problem to be here. Best Regards |
Pull Request checklist
Note: these are not necessarily requirements
Pull Request description
This adds bdm hdd support adapted from @grimdoomer fork. Only additions are if one hdd option is ON the other will be disabled to try avoid conflicts.