Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui improvements #1342

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

Gui improvements #1342

wants to merge 9 commits into from

Conversation

Wolf3s
Copy link
Contributor

@Wolf3s Wolf3s commented Oct 13, 2024

Pull Request checklist

Note: these are not necessarily requirements

  • I reformatted the code with clang-format
  • I checked to make sure my submission worked
  • I am the author of submission or have permission from the original author
  • Requires update of the PS2SDK or other dependencies
  • Others (please specify below)

Pull Request description

authored by @rickgaiser from the following sources:
https://gitlab.com/ps2max/Open-PS2-Loader/-/commit/cec658b7e599926b8a5b10fb31f56a78e3decee3
https://gitlab.com/ps2max/Open-PS2-Loader/-/commit/7b88863d3c398b3b6fa215393f052fdfc3416bcb
https://gitlab.com/ps2max/Open-PS2-Loader/-/commit/426575e213fe99b360c1413733ba6437c5e51806
This pr superceeds follows up: #1341

Wolf3s and others added 5 commits October 13, 2024 08:34
Fixes crashes when changing video modes. Especially when changing HIRES
modes since they use threads also.

Co-Authored-By: Rick Gaiser <[email protected]>
@rickgaiser
Copy link
Member

These commits are part of an unfinished project, called HIRES background. The tech behind this is ready and already upstreamed in gsKit, but never used in OPL.

You are ofcourse free to use whatever code you like from my repositories. But why?

@Wolf3s
Copy link
Contributor Author

Wolf3s commented Oct 17, 2024

These commits are part of an unfinished project, called HIRES background. The tech behind this is ready and already upstreamed in gsKit, but never used in OPL.

You are ofcourse free to use whatever code you like from my repositories. But why?

This pr was made because i spoke with krah about this repository and related with 240p and we both agreed to add this to open ps2 loader but i left him first deal with 240p resolution then me with this patch, Also when this call: guiStartFrame it´s the same call with the diffrence that it´s thread lock for the gui. The only tech that i saw which is rebased from gsKit is: renderman.c on this pr which i will probablly see this.

@Wolf3s
Copy link
Contributor Author

Wolf3s commented Oct 17, 2024

These commits are part of an unfinished project, called HIRES background. The tech behind this is ready and already upstreamed in gsKit, but never used in OPL.

You are ofcourse free to use whatever code you like from my repositories. But why?

I have knowledge that because i compared every change on your repository and 70% is all merged but i didn´t rebased every commit.

@Wolf3s Wolf3s marked this pull request as ready for review October 18, 2024 22:33
@AKuHAK AKuHAK marked this pull request as draft November 15, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants