Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit tests for recent Bazel versions. For #342. #347

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix unit tests for recent Bazel versions. For #342. #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d324da7
Fix unit tests for recent Bazel versions.
martijneken Apr 28, 2023
e2417ea
Allow noop parameterized tests when engine=null
martijneken Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,9 @@ def proxy_wasm_cpp_host_repositories():
maybe(
http_archive,
name = "com_google_googletest",
sha256 = "9dc9157a9a1551ec7a7e43daea9a694a0bb5fb8bec81235d8a1e6ef64c716dcb",
strip_prefix = "googletest-release-1.10.0",
urls = ["https://github.com/google/googletest/archive/release-1.10.0.tar.gz"],
sha256 = "ad7fdba11ea011c1d925b3289cf4af2c66a352e18d4c7264392fead75e919363",
strip_prefix = "googletest-1.13.0",
url = "https://github.com/google/googletest/archive/v1.13.0.tar.gz",
)

# NullVM dependencies.
Expand Down
1 change: 1 addition & 0 deletions test/exports_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVm, testing::ValuesIn(getWasmEngines()
[](const testing::TestParamInfo<std::string> &info) {
return info.param;
});
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(TestVm); // noop for engine=null

TEST_P(TestVm, Environment) {
std::unordered_map<std::string, std::string> envs = {{"KEY1", "VALUE1"}, {"KEY2", "VALUE2"}};
Expand Down
1 change: 1 addition & 0 deletions test/runtime_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVm, testing::ValuesIn(getWasmEngines()
[](const testing::TestParamInfo<std::string> &info) {
return info.param;
});
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(TestVm); // noop for engine=null

TEST_P(TestVm, BadSignature) {
auto source = readTestWasmFile("clock.wasm");
Expand Down
1 change: 1 addition & 0 deletions test/security_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVm, testing::ValuesIn(getWasmEngines()
[](const testing::TestParamInfo<std::string> &info) {
return info.param;
});
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(TestVm); // noop for engine=null

TEST_P(TestVm, MallocNoHostcalls) {
if (engine_ != "v8") {
Expand Down
1 change: 1 addition & 0 deletions test/wasm_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVm, testing::ValuesIn(getWasmEngines()
[](const testing::TestParamInfo<std::string> &info) {
return info.param;
});
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(TestVm); // noop for engine=null

// Fail callbacks only used for WasmVMs - not available for NullVM.
TEST_P(TestVm, GetOrCreateThreadLocalWasmFailCallbacks) {
Expand Down
1 change: 1 addition & 0 deletions test/wasm_vm_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ INSTANTIATE_TEST_SUITE_P(WasmEngines, TestVm, testing::ValuesIn(getWasmEngines()
[](const testing::TestParamInfo<std::string> &info) {
return info.param;
});
GTEST_ALLOW_UNINSTANTIATED_PARAMETERIZED_TEST(TestVm); // noop for engine=null

TEST_P(TestVm, Basic) {
if (engine_ == "wasmedge") {
Expand Down