Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to prefix_wasm_api #420

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

keithmattix
Copy link
Contributor

@keithmattix keithmattix commented Sep 26, 2024

References to include/wasm.h changed to crates/c-api/include/wasm.h, so the prefixed api output needs to change as well. Fixes #418

Signed-off-by: Keith Mattix II <[email protected]>
@PiotrSikora
Copy link
Member

@keithmattix The change looks fine, but could you please confirm that it fixes the build and tests with --define=engine=multi? The CI doesn't check that configuration due to time constraints. Thanks!

@keithmattix
Copy link
Contributor Author

@PiotrSikora I at least got past the error @wbpcode reported in #418, but am now dealing with wasmedge failures. I haven't been able to get past them yet, but will keep trying. If @wbpcode has a working setup, they may be able to confirm before I can. I think the wasmedge compilation step is considering all of my warnings as errors and I'm trying to find where I can disable that

@PiotrSikora
Copy link
Member

@wbpcode @mpwarres could you verify if this fixes the multi-engine builds?

@krinkinmu
Copy link

krinkinmu commented Oct 4, 2024

@PiotrSikora FWIW, I faced the same problem as in #418 and arrived to the same fix as @keithmattix did. I checked that it addresses the problem for me and the command from #418 works for me now:

bazel build --define=engine=multi :lib
INFO: Build option --define has changed, discarding analysis cache.
INFO: Analyzed target //:lib (0 packages loaded, 71587 targets configured).
INFO: Found 1 target...
Target //:lib up-to-date (nothing to build)
INFO: Elapsed time: 3.186s, Critical Path: 0.70s
INFO: 1 process: 1 internal.
INFO: Build completed successfully, 1 total action

Would it count as verification enough to merge this PR?

Copy link
Member

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@PiotrSikora
Copy link
Member

@mpwarres @martijneken could you guys review and merge it? Thanks!

@PiotrSikora
Copy link
Member

@mpwarres @martijneken could you guys review and merge it? Thanks!

Ping?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build failture with wasmtime
3 participants