Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] deps: Bump proxy_wasm_cpp_host -> 3212034 (+deps) #36857

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

dependency-envoy[bot]
Copy link
Contributor

Created by Envoy dependency bot for @phlax

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 28, 2024
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #36857 was opened by dependency-envoy[bot].

see: more, trace.

Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>

Signed-off-by: Ryan Northey <[email protected]>
@phlax phlax changed the title deps: Bump proxy_wasm_cpp_host -> 3212034 deps: Bump proxy_wasm_cpp_host -> 3212034 (+deps) Oct 28, 2024
@phlax
Copy link
Member

phlax commented Oct 28, 2024

/retest kafka download

Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
@phlax
Copy link
Member

phlax commented Oct 28, 2024

cc @PiotrSikora i have attempted an update to wasmtime 24.0.0 here and included related deps as suggested

im hitting

In file included from external/src/wasmtime/wasmtime.cc:27:
external/proxy_wasm_cpp_host/src/wasmtime/types.h:16:10: fatal error: 'crates/c-api/include/wasm.h' file not found
#include "crates/c-api/include/wasm.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

https://github.com/envoyproxy/envoy/actions/runs/11552408274/job/32151480980#step:12:4035

i tried to include proxy-wasm/proxy-wasm-cpp-host#420 as a patch - but that didnt help

@PiotrSikora
Copy link
Contributor

@keithmattix did you test your Wasmtime update with Envoy? Could you take a look at this failure?

cc @mpwarres

@keithmattix
Copy link
Contributor

Yeah I'll take a look; there may be some references in envoy that need to updated

@keithmattix
Copy link
Contributor

keithmattix commented Oct 28, 2024

Ah I see; Envoy is still using the old wasm-c-api path; I will push a fix

@keithmattix
Copy link
Contributor

This is as far as I could get: #36880

@phlax phlax changed the title deps: Bump proxy_wasm_cpp_host -> 3212034 (+deps) [WIP] deps: Bump proxy_wasm_cpp_host -> 3212034 (+deps) Oct 29, 2024
@phlax phlax marked this pull request as draft October 29, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants