-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] deps: Bump proxy_wasm_cpp_host
-> 3212034 (+deps)
#36857
base: main
Are you sure you want to change the base?
[WIP] deps: Bump proxy_wasm_cpp_host
-> 3212034 (+deps)
#36857
Conversation
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com> Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com> Signed-off-by: Ryan Northey <[email protected]>
proxy_wasm_cpp_host
-> 3212034proxy_wasm_cpp_host
-> 3212034 (+deps)
/retest kafka download |
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: Ryan Northey <[email protected]>
cc @PiotrSikora i have attempted an update to wasmtime 24.0.0 here and included related deps as suggested im hitting In file included from external/src/wasmtime/wasmtime.cc:27:
external/proxy_wasm_cpp_host/src/wasmtime/types.h:16:10: fatal error: 'crates/c-api/include/wasm.h' file not found
#include "crates/c-api/include/wasm.h"
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ https://github.com/envoyproxy/envoy/actions/runs/11552408274/job/32151480980#step:12:4035 i tried to include proxy-wasm/proxy-wasm-cpp-host#420 as a patch - but that didnt help |
@keithmattix did you test your Wasmtime update with Envoy? Could you take a look at this failure? cc @mpwarres |
Yeah I'll take a look; there may be some references in envoy that need to updated |
Ah I see; Envoy is still using the old wasm-c-api path; I will push a fix |
This is as far as I could get: #36880 |
proxy_wasm_cpp_host
-> 3212034 (+deps)proxy_wasm_cpp_host
-> 3212034 (+deps)
Created by Envoy dependency bot for @phlax
Signed-off-by: dependency-envoy[bot] <148525496+dependency-envoy[bot]@users.noreply.github.com>