Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remote-write to Prombench #787

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Add remote-write to Prombench #787

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1eab9a1
Created Service and Deployment configuration for Prometheus sink
kushalShukla-web Nov 14, 2024
5d1d7c1
1. Added cpu and memory usage to remote-write.
kushalShukla-web Nov 25, 2024
83d5e7d
Removed Limit section for now.
kushalShukla-web Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions prombench/manifests/prombench/benchmark/3a_prometheus-test_configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,3 +718,5 @@ data:
- action: replace
source_labels: [__meta_kubernetes_pod_node_name]
target_label: nodeName
remote_write:
- url: "http://prometheus-remote-write:80/sink/prw"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the red mark.

41 changes: 41 additions & 0 deletions prombench/manifests/prombench/benchmark/7_prometheus_remote_write.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: prometheus-sink
namespace: prombench-{{ .PR_NUMBER }}
spec:
replicas: 1
selector:
matchLabels:
app: sink
template:
metadata:
namespace: prombench-{{ .PR_NUMBER }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally containers inherit the namespace from the Deployment.
Maybe it will work.

labels:
app: sink
spec:
containers:
bboreham marked this conversation as resolved.
Show resolved Hide resolved
- name: prom-sink
image: quay.io/bwplotka/sink:latest
imagePullPolicy: Always
ports:
- name: sink-port
containerPort: 9011
nodeSelector:
node-name: nodes-{{ .PR_NUMBER }}
isolation: none
---
apiVersion: v1
kind: Service
metadata:
name: prometheus-remote-write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be easier if this were named the same as the Deployment.
That's the pattern used for fake-webserver, prometheus-loadgen-querier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay.

namespace: prombench-{{ .PR_NUMBER }}
labels:
app: remote-write
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be consistent with other app labels in this file.
That's the point, to group them all together.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i did not knew that.

spec:
ports:
- name: prometheus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems potentially confusing; it's not a Prometheus.

port: 80
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? (It doesn't really matter, but I would have stuck with 9011)

targetPort: sink-port
selector:
app: sink