Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Go standard errors #619

Merged
merged 1 commit into from
Oct 14, 2024
Merged

use Go standard errors #619

merged 1 commit into from
Oct 14, 2024

Conversation

mmorel-35
Copy link
Contributor

  • Since Dec 1, 2021, github.com/pkg/errors is an archived project.
  • Since go 1.13, there is a standard errors and fmt modules that provides equivalent ways to handle errors.

Signed-off-by: Matthieu MOREL [email protected]

@mmorel-35
Copy link
Contributor Author

Anything left to merge this ?

bboreham
bboreham reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@bboreham bboreham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me, but I am not familiar with the code.

It seems some more linting was turned on, which prompted some other, mostly cosmetic, changes. I always look for consistency between the description and the diffs, since it can reveal changes included by mistake.

tools/fake-webserver/server.go Outdated Show resolved Hide resolved
@mmorel-35 mmorel-35 marked this pull request as draft January 15, 2024 21:54
@mmorel-35
Copy link
Contributor Author

I'll narrow this to fit title and provide another PR for the formarring

@bwplotka
Copy link
Member

Friendly ping, would be nice to improve things (: Thanks!

@mmorel-35 mmorel-35 force-pushed the errors branch 5 times, most recently from f06cdc8 to 9c321f7 Compare October 14, 2024 10:59
@mmorel-35 mmorel-35 marked this pull request as ready for review October 14, 2024 10:59
@mmorel-35
use Go standard errors
67c5b54 
Signed-off-by: Matthieu MOREL <[email protected]>
@mmorel-35
Copy link
Contributor Author

@bwplotka ,
That's ready for review

bwplotka
bwplotka approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!!

@bwplotka bwplotka merged commit 7427925 into prometheus:master Oct 14, 2024
4 checks passed
@mmorel-35 mmorel-35 deleted the errors branch October 14, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bboreham bboreham bboreham left review comments

@bwplotka bwplotka bwplotka approved these changes

@metalmatze metalmatze metalmatze approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmorel-35 @bwplotka @metalmatze @bboreham