Fix Exceptions are not handled on premain (#873)

* Fix Exceptions are not handled on premain Signed-off-by: guhanjie <[email protected]>
prometheus · Aug 17, 2023 · 34e9841 · 34e9841
1 parent 18d94bd
commit 34e9841
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/jmx_prometheus_javaagent/src/main/java/io/prometheus/jmx/JavaAgent.java b/jmx_prometheus_javaagent/src/main/java/io/prometheus/jmx/JavaAgent.java
@@ -62,14 +62,15 @@ public static void premain(String agentArgument, Instrumentation instrumentation
                                     CollectorRegistry.defaultRegistry,
                                     true,
                                     new File(config.file));
-        } catch (ConfigurationException e) {
-            System.err.println("Configuration Exception : " + e.getMessage());
-            System.exit(1);
-        } catch (IllegalArgumentException e) {
-            System.err.println(
-                    "Usage: -javaagent:/path/to/JavaAgent.jar=[host:]<port>:<yaml configuration"
-                            + " file> "
-                            + e.getMessage());
+        } catch (Throwable t) {
+            synchronized (System.err) {
+                System.err.println("Failed to start Prometheus JMX Exporter");
+                System.err.println();
+                t.printStackTrace();
+                System.err.println();
+                System.err.println("Prometheus JMX Exporter exiting");
+                System.err.flush();
+            }
             System.exit(1);
         }
     }
@@ -88,7 +89,9 @@ public static Config parseConfig(String args, String ifc) {
 
         Matcher matcher = pattern.matcher(args);
         if (!matcher.matches()) {
-            throw new IllegalArgumentException("Malformed arguments - " + args);
+            System.err.println(
+                    "Usage: -javaagent:/path/to/JavaAgent.jar=[host:]<port>:<yaml configuration file> ");
+            throw new ConfigurationException("Malformed arguments - " + args);
         }
 
         String givenHost = matcher.group(1);