Skip to content

Commit

Permalink
testutil: include MetricFamilies without timeseries
Browse files Browse the repository at this point in the history
Signed-off-by: Damien Grisonnet <[email protected]>
  • Loading branch information
dgrisonnet committed Oct 10, 2024
1 parent a5a828e commit 7df9e2d
Showing 1 changed file with 23 additions and 1 deletion.
24 changes: 23 additions & 1 deletion prometheus/testutil/testutil.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import (
"fmt"
"io"
"net/http"
"sort"

"github.com/kylelemons/godebug/diff"
dto "github.com/prometheus/client_model/go"
Expand Down Expand Up @@ -251,6 +252,7 @@ func CollectAndFormat(c prometheus.Collector, format expfmt.FormatType, metricNa
// dto.MetricFamily.
func convertReaderToMetricFamily(reader io.Reader) ([]*dto.MetricFamily, error) {
var tp expfmt.TextParser
tp.IncludeEmptyMetricFamilies(true)
notNormalized, err := tp.TextToMetricFamilies(reader)
if err != nil {
return nil, fmt.Errorf("converting reader to metric families failed: %w", err)
Expand All @@ -270,7 +272,27 @@ func convertReaderToMetricFamily(reader io.Reader) ([]*dto.MetricFamily, error)
}
}

return internal.NormalizeMetricFamilies(notNormalized), nil
a := normalizeMetricFamilies(notNormalized)
return a, nil
}

// normalizeMetricFamilies is a copy of Prometheus
// internal.NormalizeMetricFamilies, but it keeps MetricFamily without
// timeseries.
func normalizeMetricFamilies(metricFamiliesByName map[string]*dto.MetricFamily) []*dto.MetricFamily {
for _, mf := range metricFamiliesByName {
sort.Sort(internal.MetricSorter(mf.Metric))
}
names := make([]string, 0, len(metricFamiliesByName))
for name := range metricFamiliesByName {
names = append(names, name)
}
sort.Strings(names)
result := make([]*dto.MetricFamily, 0, len(names))
for _, name := range names {
result = append(result, metricFamiliesByName[name])
}
return result
}

// compareMetricFamilies would compare 2 slices of metric families, and optionally filters both of
Expand Down

0 comments on commit 7df9e2d

Please sign in to comment.