Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I made a small change to the compile_support.rb... #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vfrride
Copy link

@vfrride vfrride commented Mar 31, 2011

I made a small change to the compile_support.rb file to check for a nil case for env["SERVER_PROTOCOL"] as it was causing a problem when I moved my project to jRuby running inside jBoss.

Thanks for all the great work on prawnto, it makes my code a lot cleaner!

Jeff

@bazlo
Copy link

bazlo commented Oct 20, 2011

@vfrride This change also fixes rendering problems with pow webserver and 2.3.x rails apps

@elia
Copy link

elia commented Nov 14, 2011

Can be also expanded to:

          @controller.request.env['SERVER_PROTOCOL']        =~ /^https$/i ||
          @controller.request.env['HTTPS']                  == 'on'       || 
          @controller.request.env['HTTP_X_FORWARDED_PROTO'] == 'https'

(from: ActionDispatch::Http::URL#ssl?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants