Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update STACK_USING_ARRAY.cpp #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update STACK_USING_ARRAY.cpp #34

wants to merge 1 commit into from

Conversation

arjunjain8887
Copy link

  1. Memory Management: Ensured proper deallocation of memory using delete[] for arrays.
  2. Error Handling: Added checks for invalid capacities and empty stack conditions.
  3. Corrected Logic: Fixed the condition in isfull() and improved overall logic flow.
  4. User Feedback: Enhanced user feedback messages to make it clearer what went wrong.
  5. Code Readability: Improved indentation and spacing for better readability.
  6. Consistent Return Types: Ensured that functions like peek() return a consistent value even in error cases.

@pravocodes
Copy link
Owner

There are conflicts with the main branch please resolve those to get merged.

@harshangvirani
Copy link
Contributor

@pravocodes please assignee this task to me

@pravocodes
Copy link
Owner

pravocodes commented Oct 13, 2024 •
edited
Loading

Yes I have assigned @harshangvirani

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pravocodes pravocodes pravocodes approved these changes

Assignees

@harshangvirani harshangvirani

Labels
good first issue Good for newcomers Hacktoberfest2024 hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arjunjain8887 @pravocodes @harshangvirani