Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add global_inflation_per_claim param to tokenomics module #951

Open
wants to merge 3 commits into
base: todo_beta/refactor/supplier_staking_fee
Choose a base branch
from
Open

feat: add global_inflation_per_claim param to tokenomics module #951

wants to merge 3 commits into from
+581 −166

Conversation

bryanchriswhite
Copy link
Contributor

Summary

Add global_inflation_per_claim param to the tokenomics module.

Issue

  • TODO_BETA

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added governance Governance related changes on-chain On-chain business logic devnet-test-e2e tokenomics Token Economics - what else do you need? consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Nov 21, 2024
@bryanchriswhite bryanchriswhite self-assigned this Nov 21, 2024
@github-actions GitHub Actions
Copy link

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 951)
Grafana network dashboard for devnet-issue-951

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Nov 21, 2024
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 21, 2024 21:43
bryanchriswhite
bryanchriswhite commented Nov 21, 2024
View reviewed changes
x/tokenomics/types/message_update_param_test.go
@@ -63,6 +63,17 @@ func TestMsgUpdateParam_ValidateBasic(t *testing.T) {
},
expectedErr: ErrTokenomicsParamInvalid,
},
{
name: "invalid: global inflation per claim less than 0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just now noticing the constraint in this comment:
image

Add a case equal to 0.

@bryanchriswhite bryanchriswhite mentioned this pull request Nov 21, 2024
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne Awaiting requested review from red-0ne

Assignees

@bryanchriswhite bryanchriswhite

Labels
consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. devnet devnet-test-e2e governance Governance related changes on-chain On-chain business logic push-image CI related - pushes images to ghcr.io tokenomics Token Economics - what else do you need?
Projects
Shannon
Status: 👀 In review
Milestone
Shannon Beta TestNet Launch
Development

Successfully merging this pull request may close these issues.
1 participant
@bryanchriswhite