Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix Docker Walkthrough gateway container name and add supplier staking note #939

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jblewnormal
Copy link

Summary

  • Changed incorrect gateway-example Docker container name to gateway under the Configure and run your Gateway Server section of Docker Compose Walkthrough.
  • Added a note clarifying one must wait till the full-node has caught up with the current block number before staking their supplier.

I have not run make docusaurus_start as changes are fairly simple and I'm assuming they run on PR submission. Will do so if requested :)

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@Olshansk Olshansk self-requested a review November 20, 2024 23:56
@Olshansk Olshansk added the documentation Improvements or additions to documentation label Nov 20, 2024
@Olshansk Olshansk added this to the Shannon Beta TestNet Launch milestone Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants