-
-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: support lib.cc #1035
Open
Lazauya
wants to merge
27
commits into
poac-dev:main
Choose a base branch
from
Lazauya:lib-building
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
build: support lib.cc #1035
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
ba22565
initial library building support
aef5ee2
remove debug print
8026e26
fmt
d7963cf
Merge pull request #1 from poac-dev/main
Lazauya 739474c
Merge remote-tracking branch 'refs/remotes/origin/main' into lib-buil…
8765dcc
merge master
3cb0dc7
rollback formatting
bac7f94
rollback something
47f8ec8
use format for lib build command
9cc8c6e
Merge branch 'poac-dev:main' into main
Lazauya d75857a
Merge remote-tracking branch 'origin/main' into lib-building
f12e007
formatting, fix uninitialized vars
3967984
formatting, fix uninitialized vars
7fc1152
fix lint errors
a32a4a6
change to fmt::format
b822f85
format
b00868f
Merge branch 'poac-dev:main' into main
Lazauya 344be4c
Merge remote-tracking branch 'origin/main' into lib-building
911d6e0
format
b28f9a9
fix build
9e58bf4
refactor build command into function
0ed1788
preallocate commands vec and make const
a2bebc9
change var names, introduce library name variables
e2da2be
Merge branch 'poac-dev:main' into main
Lazauya 48c07e4
Merge remote-tracking branch 'refs/remotes/origin/main' into lib-buil…
1bc082f
move libname to BuildConfig and fix formatting
1452d25
combine defineLib/LinkTarget into single func, rename executable to b…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this line looks awkward. Can you also please move this to the constructor body?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang tidy throws an error if I do that.