Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect verbosity option changes for Makefile #1000

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

ken-matsui
Copy link
Member

Prior to this patch, -q option was not propagated to the generated Makefile correctly:

$ poac b             
 Compiling <package name>
  Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.83s

$ poac b -q
 Compiling <package name>

This is because Makefile is generated based on Poac's option and will not reflect the option until it is regenerated.

This patch instead generates Makefile, which takes option info dynamically. Also, this patch avoids printing Compiling <package name> when the target is cached.

@ken-matsui ken-matsui merged commit b05bf18 into main Oct 4, 2024
17 checks passed
@ken-matsui ken-matsui deleted the reflect-option-changes branch October 4, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant