Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an improperly configured baseurl, which was causing links to have // #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxthomas
Copy link

hey there, was poking around on this library and wanted to see the linked strange loop post, but got a 404 from the link.

turns out i think jekyll is creating an extra / character in links to posts on your site, e.g. the about link is:

https://plumatic.github.io//about/

other posts:

https://plumatic.github.io//prismatics-graph-at-strange-loop

etc. i'm not a jekyll expert but i'm guessing this isn't desired behavior!

i believe this is due to a misconfigured baseurl, which this PR fixes. you can read more about this here. but basically since the blog is in the root path, you don't need baseurl, it seems...

@w01fe
Copy link
Member

w01fe commented Apr 5, 2017

Thanks! That link was actually broken due to the trailing slash in the link from the README (now fixed) -- it seems to accept one or two leading slashes with no problem. This change sounds like the right thing but I'm also a bit hesitant to mess with it since I think things are otherwise working. I'll leave this open and maybe loop back to it when I have more time to mess around.

Thanks again!

@maxthomas
Copy link
Author

cool, no worries. if you're rustling around in that README.md you may want to add a newline here as well:

<a name="fnk"/>
 ## Bring on (de)fnk 

as it stands it's not rendering properly (see here then find for ##)

@w01fe
Copy link
Member

w01fe commented Apr 5, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants