-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to customise type displays #363
base: main
Are you sure you want to change the base?
Conversation
I'll take a deeper dive later today, but I wanted to give initial feedback that this is one of the most comprehensive PRs I've ever received for the project. Deeply appreciate that not only did you change the code, but you:
Honestly just all around 👏👏👏 |
Least I could do considering the many days your project saved me! I wrote a codegen CLI by hand in the past and I can appreciate how useful Plop is. Looking forward to your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Add missing type defs in node-plop and reexport them in plop
Hi @crutchcorn, just in case you're waiting for me to take care of the above task to do a review, I'm waiting for a review to make batch fixes to the branch 😅 |
Overall this code looks awesome @Sidnioulz - apologies for the massive delay in the review. If you want to finish up the last remaining tasks I'll merge this ASAP :) |
Thanks, I think it should be done now. I've reformatted (amended the initial commit) and added type declarations to the NodePlopAPI (separate commit). Leaving this in your hands :-) |
Hi @crutchcorn, any chance you look at this in the coming weeks? To the best of my knowledge, the Besides that, do you need help maintaining this package? |
This PR adds the ability to set the display characters for any action type. It works both for custom action types and for built-in ones.
Some notes:
setActionType
to allow for setting both the type and the display together, but I am unsure of the consequences considering howloadAsset
works innode-plop