Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set alt attribute in tag method by default #77

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

cekk
Copy link
Member

@cekk cekk commented Apr 18, 2019

Fixes #76

Tag method shouldn't return a useless title attribute, so right now it is optional.
Alt tag shouldn't be redundant, so it cannot be the title or description. Right now it reads new alt_text attribute from Image content-type and lead image and return it as alt html attribute.

@mister-roboto
Copy link

@cekk thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@cekk
Copy link
Member Author

cekk commented Apr 18, 2019

@jenkins-plone-org please run jobs

@jensens jensens closed this Dec 22, 2021
@jensens jensens reopened this Dec 22, 2021
@mister-roboto
Copy link

@cekk thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@jensens
Copy link
Member

jensens commented Dec 22, 2021

@jenkins-plone-org please run jobs

@thet thet added the 99 tag: bssp Potential task for the Buschenschanksprint label Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale method should return alt text for images and lead images
5 participants