Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currency
structure is too complicated to be used as astruct
.Currency
as astruct
stands at 72 bytes, which is too large.default
forCurrency
is an invalid value where it can break things down the line.Also I've cleaned up most constructors to have consistent validation logic for creating a new
Currency
by funneling them to a singleprivate
constructor. However, there still is a loophole where an invalid currency can be created through JSON deserialization. This is due to the JSON format ofCurrency
having a yet another scheme that is different from the one forIValue
or forHash
. 🙄