reproduce #836 #1316
Draft
reproduce #836 #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geier
force-pushed
the
reproduce/836
branch
2 times, most recently
from
5fb881b
to
7741344
Compare
geier
force-pushed
the
reproduce/836
branch
2 times, most recently
from
a8b54ea
to
5d2e569
Compare
geier
force-pushed
the
reproduce/836
branch
2 times, most recently
from
773ff54
to
663fef4
Compare
When checking if days are the current or the next day, we did not take the local timezone into account. Therefore, if the local timezone was not UTC, the previous or next day could erroneously be detected as `today` (same error for `tomorrow`).
The default (today) was until now not localized, but today in UTC was assumed. This could lead to commands such as `khal calendar` starting to show events from with either the previous or the next day instead of today.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #836