Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate dataset_description.json and README.md when they do not exist and update the json file when the subject is missing #255

Merged
merged 18 commits into from
Jun 18, 2020
Merged

Generate dataset_description.json and README.md when they do not exist and update the json file when the subject is missing #255

merged 18 commits into from
Jun 18, 2020

Conversation

vinferrer
Copy link
Collaborator

@vinferrer vinferrer commented Jun 18, 2020 •
edited
Loading

Closes #243

Proposed Changes

  • Generate dataset_description.json if it doesn't exist already.
  • Generate README if it doesn't exist already.

@vinferrer vinferrer added Enhancement New feature or request BrainHack This issue is suggested for BrainHack participants! labels Jun 18, 2020
@vinferrer vinferrer closed this Jun 18, 2020
@vinferrer vinferrer reopened this Jun 18, 2020
@vinferrer vinferrer marked this pull request as draft June 18, 2020 07:59
@codecov
Copy link

codecov bot commented Jun 18, 2020 •
edited
Loading

Codecov Report

Merging #255 into master will increase coverage by 0.11%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
+ Coverage   93.55%   93.66%   +0.11%     
==========================================
  Files           8        8              
  Lines         729      742      +13     
==========================================
+ Hits          682      695      +13     
  Misses         47       47
Impacted Files Coverage Δ
phys2bids/phys2bids.py 89.83% <85.71%> (+0.08%) ⬆️
phys2bids/bids.py 89.32% <100.00%> (+1.40%) ⬆️

@eurunuela eurunuela self-assigned this Jun 18, 2020
@eurunuela eurunuela added Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) and removed BrainHack This issue is suggested for BrainHack participants! Enhancement New feature or request labels Jun 18, 2020
@eurunuela eurunuela changed the title Generate dataset_description.json and README if they doesn't exist or update it if subject is missing in the file Generate dataset_description.json and README.md when they do not exist and update the json file when the subject is missing Jun 18, 2020
@vinferrer vinferrer marked this pull request as ready for review June 18, 2020 09:34
@vinferrer
Copy link
Collaborator Author

@eurunuela, @smoia I think this is ready for review

eurunuela
eurunuela requested changes Jun 18, 2020
View reviewed changes
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix linting errors.

phys2bids/bids.py Outdated Show resolved Hide resolved
phys2bids/phys2bids.py Outdated Show resolved Hide resolved
phys2bids/phys2bids.py Outdated Show resolved Hide resolved
phys2bids/tests/test_bids.py Outdated Show resolved Hide resolved
phys2bids/tests/test_bids.py Outdated Show resolved Hide resolved
phys2bids/bids.py Outdated Show resolved Hide resolved
@eurunuela eurunuela requested a review from smoia June 18, 2020 10:05
vinferrer and others added 8 commits June 18, 2020 12:08
@vinferrer @eurunuela
Update phys2bids/bids.py
dcc9774 
lower case function

Co-authored-by: Eneko Uruñuela <[email protected]>
@vinferrer @eurunuela
Update phys2bids/phys2bids.py
a1076bd 
lower case function in phys2bids call

Co-authored-by: Eneko Uruñuela <[email protected]>
@vinferrer @eurunuela
Update phys2bids/tests/test_bids.py
3632678 
lower case function in import

Co-authored-by: Eneko Uruñuela <[email protected]>
@vinferrer @eurunuela
Update phys2bids/tests/test_bids.py
881ab98 
lower case function in call test_bids.py

Co-authored-by: Eneko Uruñuela <[email protected]>
@vinferrer @eurunuela
Update phys2bids/bids.py
ec31547 
change function changes

Co-authored-by: Eneko Uruñuela <[email protected]>
@vinferrer
change name to README.md
27c7e11
@vinferrer
lowercase function in call
8cab228
@vinferrer
change name to README.md
fcb1a61
@vinferrer
Copy link
Collaborator Author

Changes implemented guys

smoia
smoia requested changes Jun 18, 2020
View reviewed changes
phys2bids/phys2bids.py Outdated Show resolved Hide resolved
phys2bids/bids.py Outdated Show resolved Hide resolved
phys2bids/bids.py Show resolved Hide resolved
eurunuela
eurunuela approved these changes Jun 18, 2020
View reviewed changes
Copy link
Collaborator

@eurunuela eurunuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you @vinferrer !

smoia
smoia requested changes Jun 18, 2020
View reviewed changes
phys2bids/phys2bids.py Outdated Show resolved Hide resolved
smoia
smoia approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@smoia smoia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@eurunuela eurunuela merged commit cd6843c into physiopy:master Jun 18, 2020
@vinferrer vinferrer deleted the dataset branch June 18, 2020 11:01
@smoia smoia added the released This issue/pull request has been released. label Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smoia smoia smoia approved these changes

@eurunuela eurunuela eurunuela approved these changes

Assignees

@eurunuela eurunuela

Labels
Minormod This PR generally closes an `Enhancement` issue. It increments the minor version (0.+1.0) released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinferrer @eurunuela @smoia