Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TopBar strings not truncated correctly by auto-width (to krypton) #220

Open
wants to merge 1 commit into
base: krypton
Choose a base branch
from
Open

TopBar strings not truncated correctly by auto-width (to krypton) #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions xml/Includes.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@
<label>$INFO[Container.FolderName, / ]</label>
<include>BreadcrumbsLabel</include>
<visible>![Container.Content() + Window.IsActive(videos)]</visible>
<visible>![Window.IsActive(MyPVRChannels.xml) | Window.IsActive(MyPVRTimers.xml) | Window.IsActive(MyPVRRecordings.xml) | Window.IsActive(MyPVRSearch.xml)]</visible>
<visible>![Window.IsActive(MyMusicPlaylistEditor.xml) | Window.IsActive(MyPics.xml) | Window.IsActive(MyMusicNav.xml) | Window.IsActive(MyPVRChannels.xml) | Window.IsActive(MyPVRTimers.xml) | Window.IsActive(MyPVRRecordings.xml) | Window.IsActive(MyPVRSearch.xml)]</visible>
</control>
<control type="label">
<label>$INFO[Container.PluginCategory, / ]</label>
Expand Down Expand Up @@ -1043,7 +1043,7 @@
<shadowcolor>text_shadow</shadowcolor>
<top>7</top>
<height>100</height>
<width>auto</width>
<width min="1" max="900">auto</width>
</include>
<include name="ColoredBackgroundImages">
<control type="image">
Expand Down
2 changes: 1 addition & 1 deletion xml/MyMusicNav.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<include>ListThumbInfoPanel</include>
</control>
<include content="TopBar">
<param name="breadcrumbs_label" value="$LOCALIZE[2]" />
<param name="breadcrumbs_label" value="$VAR[BreadcrumbsMusicVar]" />
</include>
<include content="BottomBar">
<param name="info_visible" value="true" />
Expand Down
2 changes: 1 addition & 1 deletion xml/MyMusicPlaylistEditor.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
</control>
</control>
<include content="TopBar">
<param name="breadcrumbs_label" value="$LOCALIZE[10503][COLOR=button_focus][/COLOR]" />
<param name="breadcrumbs_label" value="$VAR[BreadcrumbsMusicPlaylistEditorVar]" />
</include>
<include>BottomBar</include>
<include content="BottomBarTwoListInfo">
Expand Down
2 changes: 1 addition & 1 deletion xml/MyPics.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@
<include>ListThumbInfoPanel</include>
</control>
<include content="TopBar">
<param name="breadcrumbs_label" value="$LOCALIZE[1213]" />
<param name="breadcrumbs_label" value="$VAR[BreadcrumbsPicsVar]" />
</include>
<include content="BottomBar">
<param name="info_visible" value="true" />
Expand Down
13 changes: 11 additions & 2 deletions xml/Variables.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,10 +331,19 @@
<value condition="Integer.IsGreater(ListItem.Playcount,0)">$INFO[ListItem.Overlay]</value>
</variable>
<!-- Breadcrumbs -->
<variable name="BreadcrumbsMusicPlaylistEditorVar">
<value>$LOCALIZE[10503] / $INFO[Container.FolderName]</value>
</variable>
<variable name="BreadcrumbsPicsVar">
<value>$LOCALIZE[1213] / $INFO[Container.FolderName]</value>
</variable>
<variable name="BreadcrumbsMusicVar">
<value>$LOCALIZE[2] / $INFO[Container.FolderName]</value>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why putting single values into a var?

</variable>
<variable name="BreadcrumbsVideoVar">
<value condition="Container.Content(movies) | String.StartsWith(container.folderpath,library://video/movies/) | String.StartsWith(container.folderpath,videodb://movies)">$LOCALIZE[20342]</value>
<value condition="Container.Content(musicvideos) | String.StartsWith(container.folderpath,library://video/musicvideos/) | String.StartsWith(container.folderpath,videodb://musicvideos)">$LOCALIZE[20389]</value>
<value condition="Container.Content(tvshows) | String.StartsWith(container.folderpath,library://video/tvshows/) | String.StartsWith(container.folderpath,videodb://tvshows)">$LOCALIZE[20343]</value>
<value condition="Container.Content(musicvideos) | String.StartsWith(container.folderpath,library://video/musicvideos/) | String.StartsWith(container.folderpath,videodb://musicvideos)">$LOCALIZE[20389] / $INFO[Container.FolderName]</value>
<value condition="Container.Content(tvshows) | String.StartsWith(container.folderpath,library://video/tvshows/) | String.StartsWith(container.folderpath,videodb://tvshows)">$LOCALIZE[20343] / $INFO[Container.FolderName]</value>
<value condition="Container.Content(seasons)">$LOCALIZE[20343]</value>
<value condition="Container.Content(episodes)">$LOCALIZE[20343]</value>
<value>$LOCALIZE[3]</value>
Expand Down